Skip to content

[executorch][native-ggml] Replay ggml graphs for repeated input shapes - #23836

Merged
digantdesai merged 1 commit into
gh/digantdesai/151/origfrom
gh/digantdesai/152/orig
Oct 14, 2026
Merged

digantdesai merged 1 commit into
gh/digantdesai/151/origfrom
gh/digantdesai/152/orig

Conversation

@pytorchbot

Copy link
Copy Markdown
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #23761 by @digantdesai
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/152/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/152/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/digantdesai/151/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/digantdesai/152/orig
Differential Revision: D123796928
@diff-train-skip-merge

Pull Request resolved: #23761

Every execute on the ggml engine rebuilt, scheduled and allocated its graph, even when the input shapes matched the previous call, as in LLM decode.

The ggml engine keeps a configurable number of built graphs per executable, keyed by input shapes, and replays them with fresh input bytes. Row indices that feed gathers and cache writes are rechecked on every replay.

Authored with Claude and Codex assistance.
ghstack-source-id: 447877040
@exported-using-ghexport

Differential Revision: [D123796928](https://our.internmc.facebook.com/intern/diff/D123796928/)
@pytorch-bot

pytorch-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23836

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 146 Pending

As of commit 0fdcd97 with merge base 0a4a05e (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 14, 2026
@digantdesai
digantdesai added this pull request to stack #23862 October 14, 2026 18:20
@digantdesai
digantdesai merged commit 2f62fb2 into main Oct 14, 2026
@digantdesai
digantdesai deleted the gh/digantdesai/152/orig branch October 14, 2026 18:26

This branch was successfully deployed

1 active deployment
cadence — 0fdcd973 Deployed Oct 14, 2026 by pytorchbot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants