Filter death + DynamicShapeUnbound gtests on Android (#19503)#19503
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19503
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 117 PendingAs of commit c2d3baa with merge base 8020fe0 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@psiddh has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104784946. |
This PR needs a
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reduces noisy/low-signal Android GTest results by filtering out tests that are known to be auto-skipped at runtime on Android (death tests due to missing fork(), and *DynamicShapeUnbound tests that currently skip via GTEST_SKIP()), using an Android-scoped GTEST_FILTER applied by the shared op_test() macro.
Changes:
- Add an Android-only
envsetting toop_test()that setsGTEST_FILTERto exclude*Diesand*DynamicShapeUnboundtests at discovery time.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
meta-codesync
Bot
changed the title
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
May 12, 2026
Summary: ~250+ ExecuTorch *_testAndroid GTests have been perpetually reported as failing in TestInfra because they are auto-skipped on every run. Death tests (*Dies) require fork(), which Android's test sandbox does not support, so gtest skips them automatically. *DynamicShapeUnbound tests hit GTEST_SKIP() at runtime because the Android-specific feature flag is unset. The result is alert fatigue for the executorch oncall and distorted CI signal. Filter these tests out at discovery time on Android only via a GTEST_FILTER env var on the shared op_test() macro. The filter is scoped through select() to ovr_config//os:android, so death tests continue to run and pass on Linux, macOS, iOS, and fbcode targets. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: ai_infra_mobile_platform Differential Revision: D104784946
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
May 12, 2026
Summary: ~250+ ExecuTorch *_testAndroid GTests have been perpetually reported as failing in TestInfra because they are auto-skipped on every run. Death tests (*Dies) require fork(), which Android's test sandbox does not support, so gtest skips them automatically. *DynamicShapeUnbound tests hit GTEST_SKIP() at runtime because the Android-specific feature flag is unset. The result is alert fatigue for the executorch oncall and distorted CI signal. Filter these tests out at discovery time on Android only via a GTEST_FILTER env var on the shared op_test() macro. The filter is scoped through select() to ovr_config//os:android, so death tests continue to run and pass on Linux, macOS, iOS, and fbcode targets. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: ai_infra_mobile_platform Differential Revision: D104784946
psiddh
added a commit
to psiddh/executorch
that referenced
this pull request
May 12, 2026
Summary: ~250+ ExecuTorch *_testAndroid GTests have been perpetually reported as failing in TestInfra because they are auto-skipped on every run. Death tests (*Dies) require fork(), which Android's test sandbox does not support, so gtest skips them automatically. *DynamicShapeUnbound tests hit GTEST_SKIP() at runtime because the Android-specific feature flag is unset. The result is alert fatigue for the executorch oncall and distorted CI signal. Filter these tests out at discovery time on Android only via a GTEST_FILTER env var on the shared op_test() macro. The filter is scoped through select() to ovr_config//os:android, so death tests continue to run and pass on Linux, macOS, iOS, and fbcode targets. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: ai_infra_mobile_platform Differential Revision: D104784946
GregoryComer
approved these changes
May 12, 2026
Summary: ~250+ ExecuTorch *_testAndroid GTests have been perpetually reported as failing in TestInfra because they are auto-skipped on every run. Death tests (*Dies) require fork(), which Android's test sandbox does not support, so gtest skips them automatically. *DynamicShapeUnbound tests hit GTEST_SKIP() at runtime because the Android-specific feature flag is unset. The result is alert fatigue for the executorch oncall and distorted CI signal. Filter these tests out at discovery time on Android only via a GTEST_FILTER env var on the shared op_test() macro. The filter is scoped through select() to ovr_config//os:android, so death tests continue to run and pass on Linux, macOS, iOS, and fbcode targets. ___ overriding_review_checks_triggers_an_audit_and_retroactive_review Oncall Short Name: ai_infra_mobile_platform Reviewed By: GregoryComer Differential Revision: D104784946
Comment on lines
+45
to
+47
| # For portable/optimized kernels, *DynamicShapeUnbound tests are also | ||
| # filtered because output_resize=false for those kernels, so they | ||
| # GTEST_SKIP() at runtime today. For the ATen kernel, output_resize=true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
~250+ ExecuTorch *_testAndroid GTests have been perpetually reported as
failing in TestInfra because they are auto-skipped on every run. Death
tests (*Dies) require fork(), which Android's test sandbox does not
support, so gtest skips them automatically. *DynamicShapeUnbound tests
hit GTEST_SKIP() at runtime because the Android-specific feature flag
is unset. The result is alert fatigue for the executorch oncall and
distorted CI signal.
Filter these tests out at discovery time on Android only via a
GTEST_FILTER env var on the shared op_test() macro. The filter is
scoped through select() to ovr_config//os:android, so death tests
continue to run and pass on Linux, macOS, iOS, and fbcode targets.
overriding_review_checks_triggers_an_audit_and_retroactive_review
Oncall Short Name: ai_infra_mobile_platform
Reviewed By: GregoryComer
Differential Revision: D104784946