Skip to content

Rename build files from TARGETS to BUCK (group ID: 778308238385783554)#19421

Open
bigfootjon wants to merge 1 commit intomainfrom
export-D104415414
Open

Rename build files from TARGETS to BUCK (group ID: 778308238385783554)#19421
bigfootjon wants to merge 1 commit intomainfrom
export-D104415414

Conversation

@bigfootjon
Copy link
Copy Markdown
Member

Reviewed By: bigfootjon

Differential Revision: D104415414

Reviewed By: bigfootjon

Differential Revision: D104415414
@bigfootjon bigfootjon requested a review from larryliu0820 as a code owner May 8, 2026 23:20
Copilot AI review requested due to automatic review settings May 8, 2026 23:20
@bigfootjon bigfootjon requested a review from kirklandsign as a code owner May 8, 2026 23:20
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 8, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19421

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 4 Pending, 1 Unclassified Failure

As of commit 510393c with merge base 9889c7c (image):

NEW FAILURES - The following jobs have failed:

UNCLASSIFIED FAILURE - DrCI could not classify the following job because the workflow did not run on the merge base. The failure may be pre-existing on trunk or introduced by this PR:

  • periodic (gh) (this job did not run on the merge base, so DrCI cannot tell whether the failure is pre-existing)

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 8, 2026
@meta-codesync
Copy link
Copy Markdown
Contributor

meta-codesync Bot commented May 8, 2026

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D104415414.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 8, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates Buck build definitions under test/ from TARGETS files into BUCK files, using fbcode_target / non_fbcode_target wrappers to preserve fbcode vs xplat behavior while unblocking builds that require BUCK presence.

Changes:

  • Remove test/TARGETS and test/end2end/TARGETS.
  • Merge the removed TARGETS definitions into test/BUCK and test/end2end/BUCK using build_file_migration.bzl wrappers.
  • Keep oncall("executorch") and @noautodeps markers in the migrated BUCK files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

File Description
test/TARGETS Deleted; targets moved into test/BUCK.
test/end2end/TARGETS Deleted; targets moved into test/end2end/BUCK.
test/end2end/BUCK Now contains migrated fbcode-only Python targets wrapped with fbcode_target.
test/BUCK Now calls define_common_targets via fbcode_target/non_fbcode_target to replace the removed TARGETS file.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/end2end/BUCK
Comment on lines 3 to +10
# @noautodeps
# add this empty BUCK file to unblock landing. Without this, we get land error like:
# "No build file at xplat/executorch/exir/BUCK when resolving target fbsource//xplat/executorch/exir:."

oncall("executorch")

# !!!! fbcode/executorch/test/end2end/TARGETS was merged into this file, see https://fburl.com/workplace/xl8l9yuo for more info !!!!

# @noautodeps
Comment thread test/end2end/BUCK
@@ -1,5 +1,103 @@
load("@fbcode_macros//build_defs:build_file_migration.bzl", "fbcode_target", "non_fbcode_target")
Comment thread test/BUCK
Comment on lines +16 to +18
load(":targets.bzl", "define_common_targets")


Comment thread test/BUCK
Comment on lines 3 to 5
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants