Skip to content

Arm backend: Fix Direct Drive release build#17758

Open
perheld wants to merge 1 commit intopytorch:mainfrom
perheld:ph-direct-drive
Open

Arm backend: Fix Direct Drive release build#17758
perheld wants to merge 1 commit intopytorch:mainfrom
perheld:ph-direct-drive

Conversation

@perheld
Copy link
Collaborator

@perheld perheld commented Feb 27, 2026

This got mixed up when moving things into a preset cmake file and the -UNDEBUG that is needed to build Release never got set.

Signed-off-by: per.held@arm.com
Change-Id: I8022efa315c9f970a29b6d6bc4a9bee0be091f8b

cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell

Copilot AI review requested due to automatic review settings February 27, 2026 14:39
@perheld perheld added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: none Do not include this in the release notes labels Feb 27, 2026
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 27, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17758

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures

As of commit 1d69ab2 with merge base 1f4ad07 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 27, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Arm Ethos-U Linux “Direct Drive” Release builds by ensuring -UNDEBUG is applied without clobbering existing Release compile flags after the preset refactor.

Changes:

  • Append -UNDEBUG to existing CMAKE_C_FLAGS_RELEASE / CMAKE_CXX_FLAGS_RELEASE rather than replacing them.
  • Force-set the cached Release flag variables so the preset reliably affects Release builds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

This got mixed up when moving things into a preset cmake file and the
-UNDEBUG that is needed to build Release never got set.

Signed-off-by: per.held@arm.com
Change-Id: I8022efa315c9f970a29b6d6bc4a9bee0be091f8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants