Arm backend: Fix Direct Drive release build#17758
Open
perheld wants to merge 1 commit intopytorch:mainfrom
Open
Arm backend: Fix Direct Drive release build#17758perheld wants to merge 1 commit intopytorch:mainfrom
perheld wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17758
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 1d69ab2 with merge base 1f4ad07 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Arm Ethos-U Linux “Direct Drive” Release builds by ensuring -UNDEBUG is applied without clobbering existing Release compile flags after the preset refactor.
Changes:
- Append
-UNDEBUGto existingCMAKE_C_FLAGS_RELEASE/CMAKE_CXX_FLAGS_RELEASErather than replacing them. - Force-set the cached Release flag variables so the preset reliably affects Release builds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
zingo
approved these changes
Feb 27, 2026
This got mixed up when moving things into a preset cmake file and the -UNDEBUG that is needed to build Release never got set. Signed-off-by: per.held@arm.com Change-Id: I8022efa315c9f970a29b6d6bc4a9bee0be091f8b
76eeb10 to
1d69ab2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This got mixed up when moving things into a preset cmake file and the -UNDEBUG that is needed to build Release never got set.
Signed-off-by: per.held@arm.com
Change-Id: I8022efa315c9f970a29b6d6bc4a9bee0be091f8b
cc @digantdesai @SS-JIA @freddan80 @per @zingo @oscarandersson8218 @mansnils @Sebastian-Larsson @robell