-
Notifications
You must be signed in to change notification settings - Fork 854
Unify Android JNI to single IRunner, wire prefill to runner #17756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
kirklandsign
wants to merge
9
commits into
main
Choose a base branch
from
android/unify-runner-wire-prefill
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+180
−154
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
bb405a6
Unify Android JNI to single IRunner, wire prefill to runner
kirklandsign 6af3dc2
Update prefill javadoc to reflect unified runner semantics
kirklandsign af0403b
Linter
kirklandsign dfe6bd6
Linter
kirklandsign 7eed30b
Fix generate() error handling and double-BOS in JNI layer
kirklandsign 9fbf0d7
Unify BOS source and document eager prefill semantics
kirklandsign f2f5444
Remove unnecessary comment block above prefill methods
kirklandsign d74c289
Include text_llm_runner.h to fix unique_ptr conversion
kirklandsign 0a3a5e4
Propagate generate() error code to Java layer
kirklandsign File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Javadoc says the
imageparameter is a “byte array”, but the API type isint[]. Update the parameter description to match the actual type (and expected value range) so callers don’t pass the wrong format.