Download QNN SDK outside of CMake for wheel builds (v2)#17751
Merged
larryliu0820 merged 2 commits intomainfrom Mar 1, 2026
Merged
Download QNN SDK outside of CMake for wheel builds (v2)#17751larryliu0820 merged 2 commits intomainfrom
larryliu0820 merged 2 commits intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17751
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Pending, 2 Unrelated FailuresAs of commit 8bcc146 with merge base f478cb3 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
This PR needs a
|
abhinaykukkadapu
approved these changes
Feb 26, 2026
larryliu0820
force-pushed
the
download-qnn-sdk-outside-cmake
branch
from
efe9333 to
39ba417
Compare
Unlike the reverted #17717 which set EXECUTORCH_BUILD_QNN=ON in pybind.cmake (causing all pybind-preset CI jobs to attempt the flaky cmake-time SDK download), this keeps QNN OFF in the preset. Only wheel builds enable it: setup.py detects QNN_SDK_ROOT and passes -DEXECUTORCH_BUILD_QNN=ON to cmake. The pre_build_script downloads the SDK before cmake runs, avoiding the flaky in-cmake download. The cmake fallback download is kept as a last resort, gated on QNN_SDK_ROOT not already being set. Also fix test_wheel_package_qnn.sh to export LD_LIBRARY_PATH so libQnnHtp.so can be found at runtime, and check InitBackend() return value in qnn_manager_lifecycle.py to prevent segfaults when QNN backend initialization fails. Co-authored-by: Claude <noreply@anthropic.com>
larryliu0820
force-pushed
the
download-qnn-sdk-outside-cmake
branch
from
39ba417 to
f37a7d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unlike the reverted #17717 which set EXECUTORCH_BUILD_QNN=ON in pybind.cmake (causing all pybind-preset CI jobs to attempt the flaky cmake-time SDK download), this keeps QNN OFF in the preset. Only wheel builds enable it: setup.py detects QNN_SDK_ROOT and passes -DEXECUTORCH_BUILD_QNN=ON to cmake.
The pre_build_script downloads the SDK before cmake runs, avoiding the flaky in-cmake download. The cmake fallback download is kept as a last resort, gated on QNN_SDK_ROOT not already being set.