Skip to content

Fix output ordering in lowered modules to prevent spec violation error#17750

Open
metascroy wants to merge 2 commits intomainfrom
fix-et-lowered-module
Open

Fix output ordering in lowered modules to prevent spec violation error#17750
metascroy wants to merge 2 commits intomainfrom
fix-et-lowered-module

Conversation

@metascroy
Copy link
Contributor

When the ExecuTorch partitioner creates submodules from a partitioned graph, _get_new_signature builds output specs by iterating the submodule's output tuple in graph order. This can produce output specs where BUFFER_MUTATION and USER_OUTPUT kinds are interleaved. The ExportedProgram verifier expects all mutation outputs to precede user outputs ([buffer_mutations..., user_outputs...]), and a misordered tuple causes a SpecViolationError.

This PR adds arrange_graph_outputs, which reorders the submodule's output tuple and output specs so that all mutation outputs (BUFFER_MUTATION, USER_INPUT_MUTATION) come before USER_OUTPUT outputs. It also remaps getitem indices on the parent graph's call_module node so the parent continues to extract the correct values after reordering.

Changes
exir/lowered_backend_module.py

Added arrange_graph_outputs() function that:

  • Reorders the submodule graph's output node to put mutation outputs first
  • Reorders output_specs in-place to match
  • Remaps getitem indices in the parent graph

Test plan:

Existing CI + new unit test

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17750

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Pending, 2 Unrelated Failures

As of commit 6e2fd3b with merge base 1f4ad07 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2026
@metascroy metascroy changed the title Fix output ordering in lowered modules Fix output ordering in lowered modules to prevent spec violation error Feb 26, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant