Voxtral Realtime: (1) convert use_standard_sdpa to backend flag (2) consistent md files#17749
Voxtral Realtime: (1) convert use_standard_sdpa to backend flag (2) consistent md files#17749mergennachin wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17749
Note: Links to docs will display an error until the docs builds have been completed. ❌ 18 New Failures, 1 Unrelated FailureAs of commit 4f141f1 with merge base 570d2e9 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
Pull request overview
This PR refactors the Voxtral Realtime model to replace a boolean configuration flag (use_standard_attention) with a more explicit string-based backend field that can specify one of three backends: "xnnpack", "metal", or "portable". This change makes the backend selection more explicit and extensible.
Changes:
- Replaced
use_standard_attention: boolconfig field withbackend: strto explicitly specify the backend ("xnnpack", "metal", or "portable") - Updated all conditional checks from boolean to string comparisons (
backend == "metal") - Updated function signatures, documentation strings, and markdown documentation to reflect the new backend parameter
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| examples/models/voxtral_realtime/model.py | Replaced use_standard_attention boolean with backend string field in config, updated all conditional logic and function signatures |
| examples/models/voxtral_realtime/model.md | Updated documentation to reflect backend field usage, corrected class names (StandardSDPA -> MetalSDPA), clarified streaming encoder backend support |
| examples/models/voxtral_realtime/export_voxtral_rt.py | Updated to pass backend parameter directly instead of computing use_standard_attention boolean |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…onsistent md files
4c65ba2 to
4f141f1
Compare
No description provided.