Skip to content

Voxtral Realtime: (1) convert use_standard_sdpa to backend flag (2) consistent md files#17749

Open
mergennachin wants to merge 1 commit intomainfrom
improve_voxtral_minor
Open

Voxtral Realtime: (1) convert use_standard_sdpa to backend flag (2) consistent md files#17749
mergennachin wants to merge 1 commit intomainfrom
improve_voxtral_minor

Conversation

@mergennachin
Copy link
Contributor

No description provided.

@mergennachin mergennachin requested a review from lucylq as a code owner February 26, 2026 21:35
Copilot AI review requested due to automatic review settings February 26, 2026 21:35
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/17749

Note: Links to docs will display an error until the docs builds have been completed.

❌ 18 New Failures, 1 Unrelated Failure

As of commit 4f141f1 with merge base 570d2e9 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 26, 2026
@github-actions
Copy link

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the Voxtral Realtime model to replace a boolean configuration flag (use_standard_attention) with a more explicit string-based backend field that can specify one of three backends: "xnnpack", "metal", or "portable". This change makes the backend selection more explicit and extensible.

Changes:

  • Replaced use_standard_attention: bool config field with backend: str to explicitly specify the backend ("xnnpack", "metal", or "portable")
  • Updated all conditional checks from boolean to string comparisons (backend == "metal")
  • Updated function signatures, documentation strings, and markdown documentation to reflect the new backend parameter

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
examples/models/voxtral_realtime/model.py Replaced use_standard_attention boolean with backend string field in config, updated all conditional logic and function signatures
examples/models/voxtral_realtime/model.md Updated documentation to reflect backend field usage, corrected class names (StandardSDPA -> MetalSDPA), clarified streaming encoder backend support
examples/models/voxtral_realtime/export_voxtral_rt.py Updated to pass backend parameter directly instead of computing use_standard_attention boolean

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants