Remove model_name param from Whisper-Metal #15798
Open
+4
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I found that the tokenizer was wrong when I run
open-ai/whisper-tinymodel usingwhisper_runnerby looking at the transcription result.Since HuggingFace has updated all Whisper model tokenizers to the v3 format, we don't need to care about the
decoder_start_token_idmanually.Solution
model_nameargument fromrun.shandmain.cppdecoder_start_token_id=50258for all models@manuelcandales