[BC Breaking] Remove runtime/core/portable_type/optional.h

[cyyever]

Summary

The usage of customised optional type has been replaced by std::optional.

[pytorch-bot]

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15586

• 📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 12 New Failures, 5 Unrelated Failures

As of commit 3ce95c8 with merge base 3f4f500 ():

NEW FAILURES - The following jobs have failed:

• Build documentation / build (buck2) / Build doc (gh)
• pull / test-vulkan-operators-linux / linux-job (gh)
  RuntimeError: Command docker exec -t 0b7a43bafea83a54a391172567a91349790d7a342b0ea62b35ea8350af715942 /exec failed with exit code 1
• pull / unittest / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 81facdf1743a05387c0d86edb45d290271cb627f9c10478860660efadead1c1a /exec failed with exit code 1
• pull / unittest / macos / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• pull / unittest / windows / windows-job (gh)
  Process completed with exit code 1.
• pull / unittest-buck / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 4d52b17f23cb731f5fb36846947b3cff21df9bf4b886d4dcc259ce72523d44f1 /exec failed with exit code 3
• pull / unittest-buck / macos / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• pull / unittest-editable / linux / linux-job (gh)
  RuntimeError: Command docker exec -t 606cc623840598f0f16a10efa18ffae566c20e1af4077a45040d55c0c890a07e /exec failed with exit code 1
• pull / unittest-editable / macos / macos-job (gh)
  RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 1
• pull / unittest-editable / windows / windows-job (gh)
  Process completed with exit code 1.
• pull / unittest-wasm-bindings (--enable-etdump) / linux-job (gh)
  RuntimeError: Command docker exec -t 778c6dcd19a1b9107c6031748ba18ebc50348432ce34b6c4e1099a8a46e4021e /exec failed with exit code 2
• pull / unittest-wasm-bindings / linux-job (gh)
  RuntimeError: Command docker exec -t d83ea5d59e9898277f8d0f9f82ca7145f4f6da70ec65e5314de97c203ef42faa /exec failed with exit code 2

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

• pull / test-models-linux (linear, portable, linux.2xlarge) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)
• pull / test-models-linux-basic (vit, portable, cmake, linux.2xlarge, executorch-ubuntu-22.04-clang12) / linux-job (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

• pull / test-binary-size-linux-gcc / linux-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• pull / test-openvino-linux / linux-job (gh) (trunk failure)
  ##[error]The operation was canceled.
• pull / test-setup-linux-gcc / linux-job (gh) (trunk failure)
  ##[error]The operation was canceled.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[cyyever]

@pytorchbot label "release notes: none"

[JacobSzwejbka]

Hmm ET exposed optional as a public type, so to avoid being bc breaking you probably need to leave the header and alias the std::optional to the et namespaces

edit: Ah the header already was doing that. Ok then probably just leave it. Its probably safer

[cyyever]

This is BC breaking, so it is up to the community to decide when to apply.

[lucylq]

Importing to internal as well to make sure we're not breaking any internal tests

[meta-codesync]

@lucylq has imported this pull request. If you are a Meta employee, you can view this in D86442644.