Skip to content

Arm backend: Add LSTM test for int16x8 #15524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Nov 11, 2025
Merged

Arm backend: Add LSTM test for int16x8 #15524

merged 6 commits into from
Nov 11, 2025

Conversation

@SaoirseARM
Copy link
Collaborator

@SaoirseARM SaoirseARM commented Nov 3, 2025 •
edited by pytorch-bot bot
Loading

Summary

Adds testcases to LSTM model unit test for in16x8 support

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15524

Note: Links to docs will display an error until the docs builds have been completed.

⏳ 1 Pending, 6 Unrelated Failures

As of commit 468cabe with merge base 2aeee9b (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2025
@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Nov 3, 2025

@pytorchbot label 'partner: arm'

@pytorch-bot pytorch-bot bot added the partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm label Nov 3, 2025
@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Nov 3, 2025

@pytorchbot label ciflow/trunk

@SaoirseARM
Copy link
Collaborator Author

SaoirseARM commented Nov 3, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Nov 3, 2025
Ninja91
Ninja91 approved these changes Nov 3, 2025
View reviewed changes
Copy link
Contributor

@Ninja91 Ninja91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zingo
Copy link
Collaborator

zingo commented Nov 6, 2025

Seem to fail :(
FAILED backends/arm/test/models/test_lstm_arm.py::test_lstm_16a8w_tosa_INT
FAILED backends/arm/test/models/test_lstm_arm.py::test_lstm_16a8w_u85_INT

@zingo
Copy link
Collaborator

zingo commented Nov 11, 2025

Seem to fail :( FAILED backends/arm/test/models/test_lstm_arm.py::test_lstm_16a8w_tosa_INT FAILED backends/arm/test/models/test_lstm_arm.py::test_lstm_16a8w_u85_INT

Might gone away after rebase, or it's flakey error, Ill tests a new rebase to retrigger a test run.

@zingo zingo merged commit 1ca3252 into pytorch:main Nov 11, 2025
290 of 297 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ninja91 Ninja91 Ninja91 approved these changes

@Sebastian-Larsson Sebastian-Larsson Awaiting requested review from Sebastian-Larsson

@digantdesai digantdesai Awaiting requested review from digantdesai digantdesai is a code owner

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SaoirseARM @zingo @Ninja91