Skip to content

Arm backend: Remove unused function build_rescale_conv_output #14141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 10, 2025
Merged

Arm backend: Remove unused function build_rescale_conv_output #14141

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3a75154
Arm backend: Remove unused function `build_rescale_conv_output`
Sebastian-Larsson Sep 8, 2025
c91a598
Merge branch 'main' into unused_function
Sebastian-Larsson Sep 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 0 additions & 37 deletions backends/arm/tosa/quant_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
from typing import Any, Tuple

import serializer.tosa_serializer as ts # type: ignore
import torch.fx
import torch.fx.node

from executorch.backends.arm._passes.fold_qdq_with_annotated_qparams_pass import (
get_input_qparams,
Expand Down Expand Up @@ -351,38 +349,3 @@ def build_rescale_from_int32(
) # type: ignore[call-arg]

return


""" Creates a TOSA rescale op based on conv2d parameters. """


def build_rescale_conv_output(
tosa_fb: Any,
op: Any,
output_name: str,
output_type: Any,
input_scale: list[float],
weight_scale: list[float],
output_scale: list[float],
output_zp: list[int],
tosa_spec=None,
):
# TODO add check to verify if this is a Per-channel quantization.
post_conv2d_scale = [
(inp * w) / out for inp, w, out in zip(input_scale, weight_scale, output_scale)
]

# For TOSA v1.0 multipliers, shifts, input_zp and output_zp are now inputs
# to the RESCALE op see: https://www.mlplatform.org/tosa/tosa_spec.html#_rescale
build_rescale(
tosa_fb=tosa_fb,
scale=post_conv2d_scale,
input_node=op,
output_name=output_name,
output_type=output_type,
input_zp=[0],
output_zp=output_zp,
rounding_mode=RoundingMode.SINGLE_ROUND,
per_channel=isinstance(weight_scale, torch.Tensor),
) # type: ignore[call-arg]
return
Loading