[Executorch][Export/ Recipes] Modify pre_edge_transform_passes, edge_transform_passes definition to take exported program and method name. #14125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…transform_passes definition to take exported program and method name. While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made: - `pre_edge_transform_passes` is now renamed to `aten_transform_passes` - `aten_transform_passes`: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgram - `aten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]` - `edge_transform_passes`: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created. - `edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]` Differential Revision: [D81730890](https://our.internmc.facebook.com/intern/diff/D81730890/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14125
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Cancelled Job, 1 Pending, 3 Unrelated FailuresAs of commit f478443 with merge base 0b78412 ( NEW FAILURES - The following jobs have failed:
CANCELLED JOB - The following job was cancelled. Please retry:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81730890 |
This PR needs a
|
…sses, edge_transform_passes definition to take exported program and method name." While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made: - `pre_edge_transform_passes` is now renamed to `aten_transform_passes` - `aten_transform_passes`: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgram - `aten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]` - `edge_transform_passes`: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created. - `edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]` Differential Revision: [D81730890](https://our.internmc.facebook.com/intern/diff/D81730890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81730890 |
…sses, edge_transform_passes definition to take exported program and method name." While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made: - `pre_edge_transform_passes` is now renamed to `aten_transform_passes` - `aten_transform_passes`: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgram - `aten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]` - `edge_transform_passes`: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created. - `edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]` Differential Revision: [D81730890](https://our.internmc.facebook.com/intern/diff/D81730890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81730890 |
…sses, edge_transform_passes definition to take exported program and method name." While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made: - `pre_edge_transform_passes` is now renamed to `aten_transform_passes` - `aten_transform_passes`: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgram - `aten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]` - `edge_transform_passes`: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created. - `edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]` Differential Revision: [D81730890](https://our.internmc.facebook.com/intern/diff/D81730890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D81730890 |
cccclai
approved these changes
Sep 10, 2025
facebook-github-bot
merged commit 9efd537
into
gh/abhinaykukkadapu/9/base
281 of 290 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
While adding QNN recipes, i realized there are gaps in pre edge and edge transform passes in the recipe logic. Where the transform passes need exported program to resolve them dynamically at runtime. Changes made:
pre_edge_transform_passesis now renamed toaten_transform_passesaten_transform_passes: now accepts list of transformation functions which takes in (method_name, ExportedProgram) and gives back ExportedProgramaten_transform_passes: Optional[List[Callable[[str, ExportedProgram], ExportedProgram]]]edge_transform_passes: Now this is a list of callables that resolves to a list of passes, callables is needed because some of the passes might need ExportedProgram which is only available during execution and not when recipe is created.edge_transform_passes: None | List[Callable[[str, ExportedProgram], List[PassType]]]Differential Revision: D81730890