Fix format string error in Android PAL initialization assert macro #14119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adicatana
requested review from
JacobSzwejbka,
lucylq and
swolchok
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14119
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 16eec55 with merge base bc18834 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D81949537 |
smeenai
approved these changes
Sep 9, 2025
adicatana
force-pushed
the
export-D81949537
branch
from
57cc84e to
9ee5a89
Compare
adicatana
added a commit
to adicatana/executorch
that referenced
this pull request
Sep 11, 2025
…ytorch#14119) Summary: The `__android_log_print` call had an extra `"%s"` format specifier that wasn't matched by the provided arguments, causing `-Werror,-Wformat-extra-args` compilation failures. Reviewed By: smeenai Differential Revision: D81949537
|
This pull request was exported from Phabricator. Differential Revision: D81949537 |
adicatana
added a commit
to adicatana/executorch
that referenced
this pull request
Sep 11, 2025
…ytorch#14119) Summary: Pull Request resolved: pytorch#14119 The `__android_log_print` call had an extra `"%s"` format specifier that wasn't matched by the provided arguments, causing `-Werror,-Wformat-extra-args` compilation failures. Reviewed By: smeenai Differential Revision: D81949537
adicatana
force-pushed
the
export-D81949537
branch
from
9ee5a89 to
ec66dce
Compare
swolchok
approved these changes
Sep 11, 2025
adicatana
force-pushed
the
export-D81949537
branch
from
ec66dce to
98795e1
Compare
adicatana
added a commit
to adicatana/executorch
that referenced
this pull request
Sep 12, 2025
…ytorch#14119) Summary: The `__android_log_print` call had an extra `"%s"` format specifier that wasn't matched by the provided arguments, causing `-Werror,-Wformat-extra-args` compilation failures. Reviewed By: smeenai Differential Revision: D81949537
|
@adicatana has exported this pull request. If you are a Meta employee, you can view the originating diff in D81949537. |
adicatana
force-pushed
the
export-D81949537
branch
from
98795e1 to
b9e6f33
Compare
adicatana
added a commit
to adicatana/executorch
that referenced
this pull request
Sep 15, 2025
…ytorch#14119) Summary: The `__android_log_print` call had an extra `"%s"` format specifier that wasn't matched by the provided arguments, causing `-Werror,-Wformat-extra-args` compilation failures. Reviewed By: smeenai Differential Revision: D81949537
|
@adicatana has exported this pull request. If you are a Meta employee, you can view the originating diff in D81949537. |
…ytorch#14119) Summary: The `__android_log_print` call had an extra `"%s"` format specifier that wasn't matched by the provided arguments, causing `-Werror,-Wformat-extra-args` compilation failures. Reviewed By: smeenai Differential Revision: D81949537
adicatana
force-pushed
the
export-D81949537
branch
from
b9e6f33 to
16eec55
Compare
|
@adicatana has exported this pull request. If you are a Meta employee, you can view the originating diff in D81949537. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The
__android_log_printcall had an extra"%s"format specifier that wasn't matched by the provided arguments, causing-Werror,-Wformat-extra-argscompilation failures.Reviewed By: smeenai
Differential Revision: D81949537