Skip to content

Conversation

MartinPavella
Copy link
Collaborator

@MartinPavella MartinPavella commented Sep 9, 2025

Summary

This PR adds a pre-processing aten dialect pass, which fuses Linear nodes with following Add nodes. This pass replaces the existing Neutron IR optimization.

Test plan

Unit tests provided.

cc @robert-kalmar

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14112

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 43ff6ad with merge base d25c35a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
@MartinPavella
Copy link
Collaborator Author

@pytorchbot label "module: nxp" "release notes: nxp"

@pytorch-bot pytorch-bot bot added module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate labels Sep 9, 2025
…e `linear` and `add` nodes.

The `linear` node supports a `bias` input which is added to the result of the matrix multiplication. Sometimes, when an `add` operator follows the `linear`, the `bias` can be modified and the `add` can be removed.
…erators.

The optimization has been replaced by an executorch aten dialect pass.
@MartinPavella MartinPavella force-pushed the upstream/main-nxp/EIEX-471-move-linear-add-fusing-to-executorch branch from 680df19 to 43ff6ad Compare September 17, 2025 06:59
@robert-kalmar robert-kalmar merged commit b158753 into pytorch:main Sep 17, 2025
126 checks passed
@robert-kalmar robert-kalmar deleted the upstream/main-nxp/EIEX-471-move-linear-add-fusing-to-executorch branch September 17, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: nxp Issues related to NXP Neutron NPU delegation and code under backends/nxp/ release notes: nxp Changes to the NXP Neutron backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants