Skip to content

Conversation

neuropilot-captain
Copy link
Collaborator

Summary

  1. Added AoT support for qwen2, qwen2.5, qwen3, gemma2, gemma3, phi3, phi4, whisper
  2. Added runner support for qwen, gemma2, phi3

TODO

  1. Add runner support for gemma3, phi4 and whisper.

Copy link

pytorch-bot bot commented Sep 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/14110

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 New Failures, 1 Cancelled Job, 3 Pending, 3 Unrelated Failures

As of commit a8ccdb6 with merge base 4d6209b (image):

NEW FAILURES - The following jobs have failed:

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 9, 2025
Copy link

github-actions bot commented Sep 9, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@neuropilot-captain neuropilot-captain force-pushed the support_qwen_phi_gemma_whisper branch from fb1ea7d to fd52664 Compare September 9, 2025 16:06
@cccclai
Copy link
Contributor

cccclai commented Sep 9, 2025

Thanks! Can you fix the lint error?

@neuropilot-captain
Copy link
Collaborator Author

Hi could you please suggest how to deal with the lint-urls and lint-xrefs errors? For lint-urls the highlighted urls are example urls in the comment section, so should be ignorable. For lint-xrefs we are not sure what the error is. Thanks!

@cccclai
Copy link
Contributor

cccclai commented Sep 10, 2025

Here is the patch

diff --git a/examples/mediatek/aot_utils/llm_utils/tokenizers_/tokenization_utils_base.py b/examples/mediatek/aot_utils/llm_utils/tokenizers_/tokenization_utils_base.py
index 14126e5bc4..f617887b13 100644
--- a/examples/mediatek/aot_utils/llm_utils/tokenizers_/tokenization_utils_base.py
+++ b/examples/mediatek/aot_utils/llm_utils/tokenizers_/tokenization_utils_base.py
@@ -1932,7 +1932,7 @@ class PreTrainedTokenizerBase(SpecialTokensMixin):
                 Will be removed in v5 of Transformers.
             proxies (`Dict[str, str]`, *optional*):
                 A dictionary of proxy servers to use by protocol or endpoint, e.g., `{'http': 'foo.bar:3128',
-                'http://hostname': 'foo.bar:4012'}`. The proxies are used on each request.
+                'http://hostname': 'foo.bar:4012'}`. The proxies are used on each request. @lint-ignore
             token (`str` or *bool*, *optional*):
                 The token to use as HTTP bearer authorization for remote files. If `True`, will use the token generated
                 when running `huggingface-cli login` (stored in `~/.huggingface`).
diff --git a/examples/mediatek/aot_utils/llm_utils/tokenizers_/utils.py b/examples/mediatek/aot_utils/llm_utils/tokenizers_/utils.py
index 8a80d5d6f6..a137e2c982 100644
--- a/examples/mediatek/aot_utils/llm_utils/tokenizers_/utils.py
+++ b/examples/mediatek/aot_utils/llm_utils/tokenizers_/utils.py
@@ -392,7 +392,7 @@ def cached_file(
             Will be removed in v5 of Transformers.
         proxies (`Dict[str, str]`, *optional*):
             A dictionary of proxy servers to use by protocol or endpoint, e.g., `{'http': 'foo.bar:3128',
-            'http://hostname': 'foo.bar:4012'}.` The proxies are used on each request.
+            'http://hostname': 'foo.bar:4012'}.` The proxies are used on each request. @lint-ignore
         token (`str` or *bool*, *optional*):
             The token to use as HTTP bearer authorization for remote files. If `True`, will use the token generated
             when running `huggingface-cli login` (stored in `~/.huggingface`).

You can run ./scripts/lint_urls.sh inside executorch folder and repro the result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants