[Backend Tester] Skip in-place activation tests due to lack of support in ET #13989
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/13989
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit e72370f with merge base ed0ab94 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
11 tasks
GregoryComer
added
the
release notes: none
digantdesai
reviewed
Sep 12, 2025
| @@ -42,5 +44,6 @@ def test_elu_f32_multi_dim(self, flow: TestFlow) -> None: | |||
| def test_elu_f32_alpha(self, flow: TestFlow) -> None: | |||
| self._test_op(Model(alpha=0.5), (torch.randn(3, 4, 5),), flow) | |||
|
|
|||
| @unittest.skip("In place activations aren't properly defunctionalized yet.") | |||
There was a problem hiding this comment.
IIRC we can only do copy_ and index_put_ today e2e
digantdesai
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are failing for all backends due to lack of defunctionalization support for in-place activations. This PR disables them to reduce noise. They can be re-enabled in the future when supported. Tracking in #11700.