Add roi_align_box_processor DSP op #12787
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12787
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit 6812650 with merge base 2c0e2a4 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78197430 |
This PR needs a
|
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 23, 2025
Summary:
Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay).
This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates.
Reviewed By: mcremon-meta, zonglinpeng, bingcy
Differential Revision: D78197430
CaptnJackSparrow
force-pushed
the
export-D78197430
branch
from
9d415ba to
866ef77
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78197430 |
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 23, 2025
Summary: Pull Request resolved: #12787 Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay). This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates. Reviewed By: mcremon-meta, zonglinpeng, bingcy Differential Revision: D78197430
CaptnJackSparrow
force-pushed
the
export-D78197430
branch
from
866ef77 to
666b203
Compare
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 24, 2025
Summary:
Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay).
This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates.
Reviewed By: mcremon-meta, zonglinpeng, bingcy
Differential Revision: D78197430
CaptnJackSparrow
force-pushed
the
export-D78197430
branch
from
666b203 to
7d35233
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78197430 |
CaptnJackSparrow
pushed a commit
that referenced
this pull request
Jul 24, 2025
Summary: Pull Request resolved: #12787 Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay). This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates. Reviewed By: mcremon-meta, zonglinpeng, bingcy Differential Revision: D78197430
CaptnJackSparrow
force-pushed
the
export-D78197430
branch
from
7d35233 to
8ad7e5b
Compare
zonglinpeng
approved these changes
Jul 24, 2025
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 24, 2025
Summary:
Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay).
This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates.
Reviewed By: mcremon-meta, zonglinpeng, bingcy
Differential Revision: D78197430
facebook-github-bot
force-pushed
the
export-D78197430
branch
from
8ad7e5b to
ddb2809
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78197430 |
Summary:
Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay).
This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates.
Reviewed By: mcremon-meta, zonglinpeng, bingcy
Differential Revision: D78197430
facebook-github-bot
force-pushed
the
export-D78197430
branch
from
ddb2809 to
6812650
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78197430 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add the necessary infra code to get the roi_align_box_processor DSP op implemented. This op is responsible for converting the roi_align box coordinates from {x1, y1, x2, y2} format to the 80 bytes encoded Turing format (described here: https://docs.google.com/document/d/1IwPvQeRq34rXg-v2qDYO_91PTZPUg1pO4ZaNN1GcjDQ/edit?fbclid=IwY2xjawLCeilleHRuA2FlbQIxMQABHkwVHvvUSalyry20nNFMMU7KbvpExm6i92gPvV_jO1gNI71Zn8WNTp2Rn7kf_aem_nbrzf940O3zNRhet8DJvHg&tab=t.0#heading=h.iiq3n6kursay).
This new op will run on the DSP and will execute as a predecessor of the turing::roi_align op which will now work with the Turing native box coordinates.
Reviewed By: mcremon-meta, zonglinpeng, bingcy
Differential Revision: D78197430