Skip to content

Qualcomm AI Engine Direct - backward compatibility CI #12748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

DannyYuyang-quic
Copy link
Collaborator

@DannyYuyang-quic DannyYuyang-quic commented Jul 23, 2025

Summary

  • add README instructions for updating Story LLaMA artifacts
  • add backward compatibility validation for Story LLaMA in CI pipeline

Test plan

./.ci/scripts/test_qnn_static_llama.sh

cc: @haowhsu-quic, @cccclai

Copy link

pytorch-bot bot commented Jul 23, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12748

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit d211129 with merge base b8fe100 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 23, 2025
@DannyYuyang-quic DannyYuyang-quic changed the title Qualcomm AI Engine Direct - backward compatibility CI backward compatibility test, do not merge Jul 23, 2025
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/llama_BC_validation branch from 398f39f to e431427 Compare July 24, 2025 03:42
@DannyYuyang-quic DannyYuyang-quic changed the title backward compatibility test, do not merge Qualcomm AI Engine Direct - backward compatibility CI Jul 24, 2025
@DannyYuyang-quic
Copy link
Collaborator Author

I've re-uploaded the story.pte file (~2MB now). I think this PR should be good to go.
model source: https://huggingface.co/karpathy/tinyllamas/tree/main/stories260K

@DannyYuyang-quic DannyYuyang-quic marked this pull request as ready for review July 24, 2025 03:49
@DannyYuyang-quic
Copy link
Collaborator Author

@pytorchbot label "release notes: qualcomm"

@pytorch-bot pytorch-bot bot added the release notes: qualcomm Changes to the Qualcomm backend delegate label Jul 24, 2025
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D78871122.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding the BC test!

@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/llama_BC_validation branch from e431427 to f0b8ce6 Compare July 24, 2025 06:28
@cccclai
Copy link
Contributor

cccclai commented Jul 24, 2025

Seems like there is still error

Traceback (most recent call last):
  File "/pytorch/executorch/backends/qualcomm/tests/test_qnn_delegate.py", line 4159, in test_llama_stories_260k
    self.fail(msg["Error"])
AssertionError: [Errno 2] No such file or directory: './outputs/inference_speed.txt'

@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/llama_BC_validation branch from f0b8ce6 to b561ac0 Compare July 25, 2025 02:27
@DannyYuyang-quic
Copy link
Collaborator Author

Seems like there is still error

Traceback (most recent call last):
  File "/pytorch/executorch/backends/qualcomm/tests/test_qnn_delegate.py", line 4159, in test_llama_stories_260k
    self.fail(msg["Error"])
AssertionError: [Errno 2] No such file or directory: './outputs/inference_speed.txt'

Thank you for taking the time to catch that! I’ll look into it and fix the error.

@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/llama_BC_validation branch from b561ac0 to f18da72 Compare July 25, 2025 05:54
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D78871122.

@cccclai
Copy link
Contributor

cccclai commented Jul 25, 2025

The CI signal seems good! Thank you. Can you also rebase?

Summary:
 - add README instructions for updating Story LLaMA artifacts
 - add backward compatibility validation for Story LLaMA in CI pipeline
 - upload .pte file for stories260k (temp workaround; may move to HF in future)
@DannyYuyang-quic DannyYuyang-quic force-pushed the dev1/danny/llama_BC_validation branch from f18da72 to d211129 Compare July 26, 2025 02:24
@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this in D78871122.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: qualcomm Changes to the Qualcomm backend delegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants