-
Notifications
You must be signed in to change notification settings - Fork 684
[ET-VK] lowering ExecuTorch tensor dtype for Vulkan tensor dtype to enable 64bit #12202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/ahmtox/30/base
Are you sure you want to change the base?
Conversation
…nable 64bit # Context We are aligning with other delegate in how they handle 64bit output dtypes. In this case, we only previously had support for integers, but this is also adding support for doubles. We convert the values in place so that we can be more performant. # Changes Add a conversion from 64bit output to 32bit output so that its compatible with vulkan. Differential Revision: [D77746134](https://our.internmc.facebook.com/intern/diff/D77746134/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/12202
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled JobsAs of commit 8ae4f88 with merge base 6669637 ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This pull request was exported from Phabricator. Differential Revision: D77746134 |
… dtype to enable 64bit" # Context We are aligning with other delegate in how they handle 64bit output dtypes. In this case, we only previously had support for integers, but this is also adding support for doubles. We convert the values in place so that we can be more performant. # Changes Add a conversion from 64bit output to 32bit output so that its compatible with vulkan. Differential Revision: [D77746134](https://our.internmc.facebook.com/intern/diff/D77746134/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746134 |
… dtype to enable 64bit" # Context We are aligning with other delegate in how they handle 64bit output dtypes. In this case, we only previously had support for integers, but this is also adding support for doubles. We convert the values in place so that we can be more performant. # Changes Add a conversion from 64bit output to 32bit output so that its compatible with vulkan. Differential Revision: [D77746134](https://our.internmc.facebook.com/intern/diff/D77746134/) cc SS-JIA manuelcandales cbilgin [ghstack-poisoned]
This pull request was exported from Phabricator. Differential Revision: D77746134 |
Hi @ahmtox! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Context
We are aligning with other delegate in how they handle 64bit output dtypes. In this case, we only previously had support for integers, but this is also adding support for doubles. We convert the values in place so that we can be more performant.
Changes
Add a conversion from 64bit output to 32bit output so that its compatible with vulkan.
Differential Revision: D77746134
cc @SS-JIA @manuelcandales @digantdesai @cbilgin