Skip to content

[3/N] Add get_option/set_option function in backend interface #11876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11391 by @cccclai
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/23/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/23/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/cccclai/22/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/cccclai/23/orig
@diff-train-skip-merge

cccclai added 3 commits June 23, 2025 21:20
Pull Request resolved: #11389

Introduce backend option as discussed in #10216

Step 1: Introducd Backend Option class

In later stage, it will be plugged in with the rest of the stack. BackendOptions is pretty much a list of BackendOption, and backend option is a key value pair. The key is a string, and the value can be 3 different types, including bool, string and int.

ghstack-source-id: 292257885

Differential Revision: [D75993712](https://our.internmc.facebook.com/intern/diff/D75993712/)
Pull Request resolved: #11390

For future needs without breacking API BC, in case we need to pass more information to the update API
ghstack-source-id: 292257886

Differential Revision: [D75919212](https://our.internmc.facebook.com/intern/diff/D75919212/)
Pull Request resolved: #11391

Add update function in backend interface class. The update function will receive the backend options from dispatched by the ET runtime.

ET runtime's logic: loop over each backend and it's corresponding backend options, dispatch the backend options to the corresponding backend

Next step, will add update API in the method and then module
ghstack-source-id: 292257883
@exported-using-ghexport

Differential Revision: [D75919242](https://our.internmc.facebook.com/intern/diff/D75919242/)
@pytorchbot pytorchbot requested a review from cccclai as a code owner June 24, 2025 08:00
Copy link

pytorch-bot bot commented Jun 24, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11876

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 33 Pending, 1 Unrelated Failure

As of commit 264d2d7 with merge base 8e49e01 (image):

NEW FAILURE - The following job has failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 24, 2025
Base automatically changed from gh/cccclai/22/orig to main June 24, 2025 17:04
@cccclai cccclai merged commit 45698d4 into main Jun 24, 2025
91 of 95 checks passed
@cccclai cccclai deleted the gh/cccclai/23/orig branch June 24, 2025 17:22
@cccclai cccclai added the release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.) label Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: api Changes to public facing apis (any interfaces, pybinded runtime methods, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants