Skip to content

Arm backend: Move Ethos-U backend to generate TOSA-1.0 #11852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Arm backend: Move Ethos-U backend to generate TOSA-1.0 #11852

wants to merge 2 commits into from

Conversation

oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Jun 23, 2025 •
edited by pytorch-bot bot
Loading

Summary

Move to use TOSA 1.0 for Vela compiler to consume. Vela compiler is updated to have support for TOSA 1.0.

Test plan

Internal and external CI unit tests.

cc @digantdesai @freddan80 @per @zingo

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jun 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11852

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 8d5694d with merge base 6d2106a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 23, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jun 23, 2025
@zingo zingo requested a review from mergennachin June 23, 2025 12:29
@zingo
Copy link
Collaborator

zingo commented Jun 23, 2025

@digantdesai and @mergennachin this one might be good to check and maybe test internally.
Vela version is updated.

@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@zingo
Copy link
Collaborator

zingo commented Jun 28, 2025

@digantdesai did you get any problem with this?

@oscarandersson8218 oscarandersson8218 force-pushed the step_vela_to_tosa-1.0 branch 2 times, most recently from 96aeb0b to db95ecd Compare June 30, 2025 12:41
@per @oscarandersson8218
Arm backend: Move Ethos-U backend to generate TOSA-1.0
6ebaf8f 
Move to use TOSA 1.0 for Vela compiler to consume.
Vela compiler is updated to have support for TOSA 1.0.

Co-authored-by: Per Åstrand <[email protected]>
Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: Ia737617241535f2a69831fd056cb0d4f9af3e6ee
@zingo
Copy link
Collaborator

zingo commented Jul 2, 2025

qnn and models fails are unrelated, they fail on main alos

@tom-arm tom-arm mentioned this pull request Jul 8, 2025
Open
@digantdesai
Copy link
Contributor

@digantdesai did you get any problem with this?

Ah yeah sorry forgot to reply. We get
RuntimeError: Compilation failed: TOSA FB Reader error : Tosa version mismatch.

I am updating vela right now. Let's hope to unblock you guys on this ASAP.

@zingo
Copy link
Collaborator

zingo commented Jul 11, 2025

I am updating vela right now. Let's hope to unblock you guys on this ASAP.

Thanks!

digantdesai
digantdesai reviewed Jul 11, 2025
View reviewed changes
@facebook-github-bot
Copy link
Contributor

@digantdesai has imported this pull request. If you are a Meta employee, you can view this in D77349665.

@zingo
Copy link
Collaborator

zingo commented Jul 15, 2025

@digantdesai do you still see any problems with this?

@tom-arm tom-arm mentioned this pull request Jul 16, 2025
Merged
@digantdesai
Copy link
Contributor

digantdesai commented Jul 16, 2025 •
edited
Loading

Yeah running into asserts because of flatbuffer issues internally. Still debugging..

For instance, like this opaque error,

RuntimeError: Compilation failed: TOSA FB Reader error: Failed to load TOSA model. Buffer contents inconsistent with generated schema

Validating that the .tosa and .json file matches between two setups.
If they do then it has to do something to do with the Vela buck-ification I assume?

I will keep you posted.

@digantdesai digantdesai mentioned this pull request Jul 16, 2025
Closed
digantdesai pushed a commit to digantdesai/executorch-1 that referenced this pull request Jul 23, 2025
@per @facebook-github-bot
Arm backend: Move Ethos-U backend to generate TOSA-1.0 (pytorch#11852)
40d9ae6 
Summary:
Move to use TOSA 1.0 for Vela compiler to consume. Vela compiler is updated to have support for TOSA 1.0.


Test Plan:
Internal and external CI unit tests.


cc digantdesai freddan80 per zingo

Reviewed By: cccclai

Differential Revision: D77349665

Pulled By: digantdesai
digantdesai pushed a commit to digantdesai/executorch-1 that referenced this pull request Jul 24, 2025
@per @facebook-github-bot
Arm backend: Move Ethos-U backend to generate TOSA-1.0 (pytorch#12780)
8f72950 
Summary:
Pull Request resolved: pytorch#12780

Move to use TOSA 1.0 for Vela compiler to consume. Vela compiler is updated to have support for TOSA 1.0.

Pull Request resolved: pytorch#11852

Test Plan:
Internal and external CI unit tests.

cc digantdesai freddan80 per zingo

Reviewed By: mcr229, cccclai

Differential Revision: D77349665

Pulled By: digantdesai
digantdesai pushed a commit to digantdesai/executorch-1 that referenced this pull request Jul 24, 2025
@per @facebook-github-bot
Arm backend: Move Ethos-U backend to generate TOSA-1.0 (pytorch#12780)
243286a 
Summary:
Pull Request resolved: pytorch#12780

Move to use TOSA 1.0 for Vela compiler to consume. Vela compiler is updated to have support for TOSA 1.0.

Pull Request resolved: pytorch#11852

Test Plan:
Internal and external CI unit tests.

cc digantdesai freddan80 per zingo

Reviewed By: mcr229, cccclai

Differential Revision: D77349665

Pulled By: digantdesai
@digantdesai
Copy link
Contributor

#12780 merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@digantdesai digantdesai digantdesai left review comments

@zingo zingo zingo left review comments

@mergennachin mergennachin Awaiting requested review from mergennachin

Assignees

@digantdesai digantdesai

Labels
ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oscarandersson8218 @zingo @facebook-github-bot @digantdesai @per