[Userbenchmark] Add configuration support for test_bench
#2592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shink
commented
Feb 12, 2025
userbenchmark/test_bench/run.py
Outdated
Comment on lines
122
to
139
| model_set = set(list_models(internal=False)) | ||
| device = config_obj["device"] | ||
| configs = [] | ||
| for model in model_set: | ||
| cfg = next(filter(lambda c: c["model"] == model, config_obj["models"]), None) | ||
| tests = cfg.get("tests", "eval") if cfg is not None else ["eval"] | ||
| for test in tests: | ||
| config = TorchBenchModelConfig( | ||
| name=model, | ||
| device=device, | ||
| test=test, | ||
| batch_size=cfg.get("batch_size", None) if cfg is not None else None, | ||
| extra_args=[], | ||
| skip=cfg is not None and cfg.get("skip", False), | ||
| ) | ||
| print(config) | ||
| configs.append(config) | ||
| return configs |
There was a problem hiding this comment.
This means that we always list all models and apply configuration on them.
|
@xuzhao9 Could you please help review this? Any comments are welcome! |
|
Hi @xuzhao9, just a gentle reminder to check this PR when you get a chance. Thanks! |
|
Hi @xuzhao9, could you please help review this?. Thanks for your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2590
Configuration file might like this: