Skip to content

Add Embedding Quantization to QAT module_swap flow #886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add Embedding Quantization to QAT module_swap flow #886

wants to merge 1 commit into from
+114 −8

Conversation

@TiRune
Copy link

@TiRune TiRune commented Sep 13, 2024

Summary: Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 13, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/886

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 431214f with merge base 72d2518 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 13, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 16, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
5259084 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 17, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
a087e50 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
jerryzh168
jerryzh168 reviewed Sep 17, 2024
View reviewed changes
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 17, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
1430e0e 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 26, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
cca9d82 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 27, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
68df007 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

TiRune added a commit to TiRune/ao that referenced this pull request Sep 27, 2024
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
03472a8 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@TiRune @facebook-github-bot
Add Embedding Quantization to QAT module_swap flow (pytorch#886)
Loading
Loading status checks…
431214f 
Summary:
Pull Request resolved: pytorch#886

Adding the embedding quantizer in the same fashion as the other module swap setup.

Differential Revision: D62664322
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D62664322

@andrewor14 andrewor14 mentioned this pull request Oct 1, 2024
Merged
andrewor14 added a commit that referenced this pull request Oct 1, 2024
@andrewor14
Add int4 weight-only embedding QAT (#947)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
Loading
Loading status checks…
5a4857e 
Based on changes in #886 by @TiRune
melvinebenezer pushed a commit to melvinebenezer/ao that referenced this pull request Oct 7, 2024
@andrewor14 @melvinebenezer
Add int4 weight-only embedding QAT (pytorch#947)
3462043 
Based on changes in pytorch#886 by @TiRune
@facebook-github-bot
Copy link
Contributor

Hi @TiRune!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@andrewor14 andrewor14 closed this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerryzh168 jerryzh168

@andrewor14 andrewor14

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

None yet

4 participants

@TiRune @facebook-github-bot @jerryzh168 @andrewor14