Fix NVFP4 QAT backward typo #3478
Merged
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/3478
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 8f09c91 with merge base 31192f2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
andrewor14
force-pushed
the
fix-nvfp4-backward
branch
2 times, most recently
from
3b71e07 to
13caba4
Compare
**Summary:** Fix `to_dtype` -> `dequantize`. This was broken in #3169. **Test Plan:** ``` python test/quantization/test_qat.py -k nvfp4_training ```
andrewor14
force-pushed
the
fix-nvfp4-backward
branch
from
13caba4 to
8f09c91
Compare
jerryzh168
approved these changes
Dec 11, 2025
danielvegamyhre
pushed a commit
that referenced
this pull request
Dec 11, 2025
**Summary:** Fix `to_dtype` -> `dequantize`. This was broken in #3169. **Test Plan:** ``` python test/quantization/test_qat.py -k nvfp4_training ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Fix
to_dtype->dequantize. This was broken in #3169.Test Plan: