-
Notifications
You must be signed in to change notification settings - Fork 294
mxfp8 training: add TP sharding strategy for dim1 kernel #2436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2436
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dc0803c with merge base 32599be ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
) | ||
# TODO(future PR): enable compile here, currently seeing | ||
# https://www.internalfb.com/phabricator/paste/view/P1851219639 | ||
# _test_lowp_mlp_tensor_parallelism_base( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to uncomment this and run ./test/prototype/mx_formats/test_mx_dtensor.sh
to reproduce
Summary:
Enables mxfp8 training with the dim1 triton kernel and TP, in eager mode. In detail:
Note that compile does not work yet, seeing https://www.internalfb.com/phabricator/paste/view/P1851219639
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: