-
Notifications
You must be signed in to change notification settings - Fork 291
Remove transpose_input
from fbgemm configs
#2422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jerryzh168
wants to merge
1
commit into
jerryzh168/stack/1
Choose a base branch
from
jerryzh168/stack/2
base: jerryzh168/stack/1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2422
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Unrelated FailuresAs of commit ed83e0a with merge base 2898903 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jerryzh168
added a commit
that referenced
this pull request
Jun 22, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
0be4845
to
59acabd
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 22, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
59acabd
to
fbae7a1
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 23, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
fbae7a1
to
8809c90
Compare
jerryzh168
added a commit
that referenced
this pull request
Jun 23, 2025
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
8809c90
to
a7778a7
Compare
a7778a7
to
a856b3d
Compare
a856b3d
to
9c2d239
Compare
Summary: This is actually not needed since people can manually transpose the weights beforehand Test Plan: ``` python test/dtypes/test_fbgemm_fp8.py -k test_bmm python test/dtypes/test_fbgemm_int4.py -k test_bmm ``` Reviewers: Subscribers: Tasks: Tags: stack-info: PR: #2422, branch: jerryzh168/stack/2
9c2d239
to
ed83e0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
CLA Signed
This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
topic: not user facing
Use this tag if you don't want this PR to show up in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs:
transpose_input
from fbgemm configs #2422Remove
transpose_input
from fbgemm configsSummary:
This is actually not needed since people can manually transpose the weights beforehand
Test Plan:
Reviewers:
Subscribers:
Tasks:
Tags: