Skip to content

Remove transpose_input from fbgemm configs #2422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: jerryzh168/stack/1
Choose a base branch
from

Conversation

jerryzh168
Copy link
Contributor

@jerryzh168 jerryzh168 commented Jun 22, 2025

Stacked PRs:


Remove transpose_input from fbgemm configs

Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:

python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm

Reviewers:

Subscribers:

Tasks:

Tags:

Copy link

pytorch-bot bot commented Jun 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2422

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 2 Unrelated Failures

As of commit ed83e0a with merge base 2898903 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

jerryzh168 added a commit that referenced this pull request Jun 22, 2025
Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:
```
python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm
```

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2422, branch: jerryzh168/stack/2
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from 0be4845 to 59acabd Compare June 22, 2025 04:33
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 22, 2025
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 22, 2025 04:35
jerryzh168 added a commit that referenced this pull request Jun 22, 2025
Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:
```
python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm
```

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2422, branch: jerryzh168/stack/2
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from 59acabd to fbae7a1 Compare June 22, 2025 04:35
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 22, 2025 04:35
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 23, 2025 22:02
jerryzh168 added a commit that referenced this pull request Jun 23, 2025
Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:
```
python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm
```

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2422, branch: jerryzh168/stack/2
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from fbae7a1 to 8809c90 Compare June 23, 2025 22:02
@jerryzh168 jerryzh168 added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jun 23, 2025
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 23, 2025 22:04
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 23, 2025 22:06
jerryzh168 added a commit that referenced this pull request Jun 23, 2025
Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:
```
python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm
```

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2422, branch: jerryzh168/stack/2
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from 8809c90 to a7778a7 Compare June 23, 2025 22:06
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 23, 2025 22:06
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 24, 2025 22:25
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from a7778a7 to a856b3d Compare June 24, 2025 22:25
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 24, 2025 22:25
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 24, 2025 22:26
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from a856b3d to 9c2d239 Compare June 24, 2025 22:26
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 24, 2025 22:26
Summary:
This is actually not needed since people can manually transpose the weights beforehand

Test Plan:
```
python test/dtypes/test_fbgemm_fp8.py -k test_bmm
python test/dtypes/test_fbgemm_int4.py -k test_bmm
```

Reviewers:

Subscribers:

Tasks:

Tags:

stack-info: PR: #2422, branch: jerryzh168/stack/2
@jerryzh168 jerryzh168 changed the base branch from jerryzh168/stack/1 to main June 24, 2025 22:28
@jerryzh168 jerryzh168 force-pushed the jerryzh168/stack/2 branch from 9c2d239 to ed83e0a Compare June 24, 2025 22:28
@jerryzh168 jerryzh168 changed the base branch from main to jerryzh168/stack/1 June 24, 2025 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants