Skip to content

make dtensor shared test util more generic #2416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh/vkuzo/88/head
Choose a base branch
from

Conversation

vkuzo
Copy link
Contributor

@vkuzo vkuzo commented Jun 20, 2025

Summary:

Refactoring to make adding MX easier in next PR, no logic change. Specifically:

  • move _test_lowp_mlp_tensor_parallelism_base to shared util file
  • move config generation out of this function to the callsite
  • instead of gating lowp allgather by rowwise flag, gate it by allgather_in_lowp flag

Test Plan:

./test/float8/test_dtensor.sh

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo
Copy link
Contributor Author

vkuzo commented Jun 20, 2025

Copy link

pytorch-bot bot commented Jun 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2416

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit 5eb2066 with merge base 4e3d019 (image):

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 20, 2025
vkuzo added a commit that referenced this pull request Jun 20, 2025
Summary:

Refactoring to make adding MX easier in next PR, no logic change.

Test Plan:

```bash
./test/float8/test_dtensor.sh
```

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: ffe4a3e
ghstack-comment-id: 2991924397
Pull Request resolved: #2416
@vkuzo vkuzo added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Jun 20, 2025
@vkuzo vkuzo requested review from drisspg and danielvegamyhre June 20, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants