Fix cache dir import #2409
Open
Fix cache dir import #2409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2409
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit bfa5900 with merge base 4e3d019 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76929618 |
|
I thought we just removed galore |
|
in #2397 |
|
@jerryzh168 No, at least this particular file is not removed in that PR. I'm not familiar with these code but let me know how you'd like to proceed. If you prefer just deleting these files, I can help with that too. |
|
I see, if your changes fixes the issue I think we can land your changes first cc @msaroufim can you comment on why galore is not fully deleted |
jerryzh168
approved these changes
Jun 20, 2025
pchen7e2
pushed a commit
to pchen7e2/ao
that referenced
this pull request
Jun 20, 2025
Summary: Starting from https://github.com/triton-lang/triton/pull/6467/files#diff-1e6a363bbde516739874d46d8ee06c60a7a76f194275b0f4d46638a0b06af8acR45, Triton exposes a different API to get the cache dir. This diff switches the call site to call that conditionally on triton versions. Reviewed By: jerryzh168 Differential Revision: D76929618
pchen7e2
force-pushed
the
export-D76929618
branch
from
74359e5 to
fbcf4dc
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76929618 |
pchen7e2
pushed a commit
to pchen7e2/ao
that referenced
this pull request
Jun 20, 2025
Summary: Pull Request resolved: pytorch#2409 Starting from https://github.com/triton-lang/triton/pull/6467/files#diff-1e6a363bbde516739874d46d8ee06c60a7a76f194275b0f4d46638a0b06af8acR45, Triton exposes a different API to get the cache dir. This diff switches the call site to call that conditionally on triton versions. Reviewed By: jerryzh168 Differential Revision: D76929618
pchen7e2
force-pushed
the
export-D76929618
branch
from
fbcf4dc to
195de46
Compare
pchen7e2
pushed a commit
to pchen7e2/ao
that referenced
this pull request
Jun 20, 2025
Summary: Starting from https://github.com/triton-lang/triton/pull/6467/files#diff-1e6a363bbde516739874d46d8ee06c60a7a76f194275b0f4d46638a0b06af8acR45, Triton exposes a different API to get the cache dir. This diff switches the call site to call that conditionally on triton versions. Reviewed By: jerryzh168 Differential Revision: D76929618
pchen7e2
force-pushed
the
export-D76929618
branch
from
195de46 to
423591a
Compare
Summary: Pull Request resolved: pytorch#2409 Starting from https://github.com/triton-lang/triton/pull/6467/files#diff-1e6a363bbde516739874d46d8ee06c60a7a76f194275b0f4d46638a0b06af8acR45, Triton exposes a different API to get the cache dir. This diff switches the call site to call that conditionally on triton versions. Reviewed By: jerryzh168 Differential Revision: D76929618
|
This pull request was exported from Phabricator. Differential Revision: D76929618 |
pchen7e2
force-pushed
the
export-D76929618
branch
from
423591a to
bfa5900
Compare
|
yeah that was a miss on my part, should just delete all the code - see #2417 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Starting from https://github.com/triton-lang/triton/pull/6467/files#diff-1e6a363bbde516739874d46d8ee06c60a7a76f194275b0f4d46638a0b06af8acR45, Triton exposes a different API to get the cache dir. This diff switches the call site to call that conditionally on triton versions.
Differential Revision: D76929618