Replace debug handle with from_node to trace operator transformation
#2339
+153
−96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2339
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
force-pushed
the
export-D76168997
branch
from
93a5321 to
dfdb1ea
Compare
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 9, 2025
pytorch#2339) Summary: This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Differential Revision: D76168997
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 9, 2025
pytorch#2339) Summary: Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Differential Revision: D76168997
Gasoonjia
force-pushed
the
export-D76168997
branch
2 times, most recently
from
0379546 to
06affa9
Compare
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 10, 2025
pytorch#2339) Summary: This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 10, 2025
Summary: X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
|
@pytorchbot label "release notes: for developer" |
|
Didn't find following labels among repository labels: release notes: for developer |
|
@pytorchbot label "topic: for developer" |
|
Didn't find following labels among repository labels: topic: for developer |
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
force-pushed
the
export-D76168997
branch
from
06affa9 to
555c2f0
Compare
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
force-pushed
the
export-D76168997
branch
from
555c2f0 to
87f8dd8
Compare
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Gasoonjia
added a commit
to Gasoonjia/ao
that referenced
this pull request
Jun 12, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
force-pushed
the
export-D76168997
branch
from
87f8dd8 to
c58121e
Compare
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 12, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added a commit
to Gasoonjia/executorch-1
that referenced
this pull request
Jun 13, 2025
pytorch#11532) Summary: Pull Request resolved: pytorch#11532 X-link: pytorch/ao#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
added
the
topic: for developers
jerryzh168
approved these changes
Jun 18, 2025
pytorch#2339) Summary: X-link: pytorch/executorch#11532 Pull Request resolved: pytorch#2339 This diff replace the debug handle with `from_node` infrastructure, which is a first class citizen in exported program and used to trace the node-level transformation by recording every ancestor of given node. N6213836 is a demonstration of how `from_node` infra records the node transformation after unlifting and re-exporting exported graph. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle with hashing their greatest ancestor's node. After this change user no longer need to invoke `generate_numeric_debug_handle` for debugging. Also the original pipeline will still work under current scenario. Reviewed By: jerryzh168 Differential Revision: D76168997
Gasoonjia
force-pushed
the
export-D76168997
branch
from
c58121e to
2b62b05
Compare
|
This pull request was exported from Phabricator. Differential Revision: D76168997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This diff replace the debug handle with
from_nodeinfrastructure, which is a first class citizen in exported program and used to trace the node-level transformation. For simplify the progress, we are trying to reuse the debug handle infrastructure by generating debug handle from from_node info via hasing.After this change user no longer need to invoke
generate_numeric_debug_handlefor debugging. Also the original pipeline will still work under current scenario.Differential Revision: D76168997