Skip to content

Conversation

@jcaip
Copy link
Contributor

@jcaip jcaip commented Mar 6, 2025

cc @petrex I tried to get this working to run some benchmarks and was running into some issues.

Does this require a specific ROCm version? I'm using 6.3.3 and I'm running into some stuff like

error: use of undeclared identifier '__builtin_amdgcn_global_load_lds'

Aside from that, I ran into a lot of issues with namespace issues with __half2, which I think I fixed by using ::__half2, and one other bug with the hip version of cudaSetAttribute needing a function pointer.

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/1847

Note: Links to docs will display an error until the docs builds have been completed.

❌ 11 New Failures

As of commit f580c78 with merge base ffb4350 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 6, 2025
@petrex
Copy link
Collaborator

petrex commented Mar 6, 2025

@jcaip let me take a look and maybe add documentation. thanks

@jcaip
Copy link
Contributor Author

jcaip commented Mar 6, 2025

Thanks @petrex, happy to share more debug info / hop on a call and walk you through the issues if that's helpful.

@jcaip jcaip mentioned this pull request Mar 11, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/rocm CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: rocm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants