Skip to content

Comprehensive Complex Numerics Support#4119

Open
narendasan wants to merge 5 commits intomainfrom
narendasan/push-uktuzstxvzvz
Open

Comprehensive Complex Numerics Support#4119
narendasan wants to merge 5 commits intomainfrom
narendasan/push-uktuzstxvzvz

Conversation

@narendasan
Copy link
Collaborator

Description

Adding comprehensive support for decomposing complex numerics and running computation through Torch-TensorRT

Fixes # (issue)

Type of change

Please delete options that are not relevant and/or add your own.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@narendasan narendasan requested review from apbose and zewenli98 March 5, 2026 18:32
@meta-cla meta-cla bot added the cla signed label Mar 5, 2026
@github-actions github-actions bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels Mar 5, 2026
github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

github-actions[bot]

This comment was marked as outdated.

@narendasan narendasan force-pushed the narendasan/push-uktuzstxvzvz branch from ea3e98a to 98555fe Compare March 5, 2026 19:25
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Mar 5, 2026
github-actions[bot]

This comment was marked as outdated.

@narendasan narendasan force-pushed the narendasan/push-uktuzstxvzvz branch from 98555fe to ab88b54 Compare March 5, 2026 19:32
github-actions[bot]

This comment was marked as outdated.

Copy link
Collaborator Author

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@apbose let me know if I added redundant infrastructure anywhere, I kind of worked from scratch

@narendasan narendasan force-pushed the narendasan/push-uktuzstxvzvz branch from ab88b54 to beda370 Compare March 5, 2026 22:40
…mplex numerics, including complex tensor I/O

Introduce a new infrastructure in the replace complex pass to handle a number of cases where simply just unpacking complex tensors is not sufficent for supporting the numerics correctly.

This pass also now captures meta data about the original call signature so that during graph construction, the original calling convention is preserved and the runtimes do not need any specialization on supporting complex types.
@narendasan narendasan force-pushed the narendasan/push-uktuzstxvzvz branch from beda370 to d6f189b Compare March 5, 2026 23:36
weight_refit_map[engine_weight_name].dtype,
]

# Stage 3: Slice matching for unmatched non-scalar CONSTANT weights.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cehongwang please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant