-
Notifications
You must be signed in to change notification settings - Fork 372
Simplify Release workflow and Add windows zip in the release artifacts #3800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
No ciflow labels are configured for this repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, only note is to put the tarball and zip builds in a separate workflow instead of in build-wheel-[linux/windows]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Simplify the release workflow by leveraging the existing repair steps in test-infra. Reuse as much as possible from test-infra and unify workflows where feasible.
Build & Test
Release
Fixes # (issue)
Type of change
Please delete options that are not relevant and/or add your own.
Checklist: