Skip to content

Change logs to asserts related to ChildStopped #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Change logs to asserts related to ChildStopped #373

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions hyperactor/src/proc.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,9 +1014,7 @@ impl<A: Actor> Instance<A> {
while self.cell.child_count() > 0 {
match self.signal_receiver.recv().await? {
Signal::ChildStopped(pid) => {
if let Some(child) = self.cell.get_child(pid) {
self.cell.unlink(&child);
}
assert!(self.cell.get_child(pid).is_none());
}
_ => (),
}
Expand Down Expand Up @@ -1061,12 +1059,7 @@ impl<A: Actor> Instance<A> {
break 'messages;
},
Signal::ChildStopped(pid) => {
let result = self.cell.get_child(pid);
if let Some(child) = result {
self.cell.unlink(&child);
} else {
tracing::debug!("received signal for unknown child pid {}", pid);
}
assert!(self.cell.get_child(pid).is_none());
},
}
}
Expand Down
Loading