[monarch] delete extra runtime #363
Open
+42
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Libraries should never create tokio runtimes; that should be up to the caller to manage. Seems that we were doing this because pyo3 threads did not have the runtime context properly set. So just fix that and zap this runtime. This cuts the number of threads we spawn in the PythonActor by a lot. Differential Revision: [D77422927](https://our.internmc.facebook.com/intern/diff/D77422927/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77422927/)! [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 27, 2025
Libraries should never create tokio runtimes; that should be up to the caller to manage. Seems that we were doing this because pyo3 threads did not have the runtime context properly set. So just fix that and zap this runtime. This cuts the number of threads we spawn in the PythonActor by a lot. Differential Revision: [D77422927](https://our.internmc.facebook.com/intern/diff/D77422927/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77422927/)! ghstack-source-id: 293027775 Pull Request resolved: #363
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D77422927 |
Libraries should never create tokio runtimes; that should be up to the caller to manage. Seems that we were doing this because pyo3 threads did not have the runtime context properly set. So just fix that and zap this runtime. This cuts the number of threads we spawn in the PythonActor by a lot. Differential Revision: [D77422927](https://our.internmc.facebook.com/intern/diff/D77422927/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77422927/)! [ghstack-poisoned]
suo
added a commit
that referenced
this pull request
Jun 27, 2025
Pull Request resolved: #363 Libraries should never create tokio runtimes; that should be up to the caller to manage. Seems that we were doing this because pyo3 threads did not have the runtime context properly set. So just fix that and zap this runtime. This cuts the number of threads we spawn in the PythonActor by a lot. ghstack-source-id: 293110124 @exported-using-ghexport Differential Revision: [D77422927](https://our.internmc.facebook.com/intern/diff/D77422927/) **NOTE FOR REVIEWERS**: This PR has internal Meta-specific changes or comments, please review them on [Phabricator](https://our.internmc.facebook.com/intern/diff/D77422927/)!
|
This pull request was exported from Phabricator. Differential Revision: D77422927 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Libraries should never create tokio runtimes; that should be up to the caller to manage.
Seems that we were doing this because pyo3 threads did not have the runtime context properly set. So just fix that and zap this runtime. This cuts the number of threads we spawn in the PythonActor by a lot.
Differential Revision: D77422927
NOTE FOR REVIEWERS: This PR has internal Meta-specific changes or comments, please review them on Phabricator!