Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimized vis classification to give ~82% Accuracy #315

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/templates/template-common/config.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
seed: 777
data_path: ./
batch_size: 32
eval_batch_size: 32
batch_size: 512
eval_batch_size: 1024
num_workers: 4
max_epochs: 20
use_amp: false
Expand Down
3 changes: 3 additions & 0 deletions src/templates/template-vision-classification/config.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
#::= from_template_common ::#
lr: 0.0001
model: resnet18
momentum: 0.9
weight_decay: 1e-4
num_warmup_epochs: 4
13 changes: 9 additions & 4 deletions src/templates/template-vision-classification/main.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,23 @@ def run(local_rank: int, config: Any):
# donwload datasets and create dataloaders
dataloader_train, dataloader_eval = setup_data(config)

# model, optimizer, loss function, device
# model, optimizer, loss function, device, lr_scheduler
device = idist.device()
model = idist.auto_model(setup_model(config.model))
optimizer = idist.auto_optim(optim.Adam(model.parameters(), lr=config.lr))
optimizer = idist.auto_optim(
optim.SGD(
model.parameters(), lr=config.lr, momentum=config.momentum, weight_decay=config.weight_decay, nesterov=True
)
)
loss_fn = nn.CrossEntropyLoss().to(device=device)
le = len(dataloader_train)
milestones_values = [
(0, 0.0),
(
len(dataloader_train),
le * config.num_warmup_epochs,
config.lr,
),
(config.max_epochs * len(dataloader_train), 0.0),
(config.max_epochs * le, 0.0),
]
lr_scheduler = PiecewiseLinear(optimizer, "lr", milestones_values=milestones_values)

Expand Down
9 changes: 6 additions & 3 deletions src/templates/template-vision-classification/trainers.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import ignite.distributed as idist
import torch
from ignite.engine import DeterministicEngine, Engine, Events
from torch.cuda.amp import autocast
from torch.cuda.amp import autocast, GradScaler
from torch.nn import Module
from torch.optim import Optimizer
from torch.utils.data import DistributedSampler, Sampler
Expand All @@ -27,9 +27,10 @@ def train_function(engine: Union[Engine, DeterministicEngine], batch: Any):
outputs = model(samples)
loss = loss_fn(outputs, targets)

loss.backward()
optimizer.step()
optimizer.zero_grad()
scaler.scale(loss).backward()
scaler.step(optimizer)
scaler.update()

train_loss = loss.item()
engine.state.metrics = {
Expand All @@ -45,6 +46,8 @@ def train_function(engine: Union[Engine, DeterministicEngine], batch: Any):

trainer = Engine(train_function)
#::: } :::#

scaler = GradScaler(enabled=config.use_amp)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's define the scaler before train_function for clarity


# set epoch for distributed sampler
@trainer.on(Events.EPOCH_STARTED)
Expand Down