Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinforcement Learning Template #276

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Reinforcement Learning Template #276

wants to merge 8 commits into from

Conversation

theory-in-progress
Copy link
Contributor

  • Added 2 algorithms for Reinforcement Learning: REINFORCE and Advantage Actor Critic (A2C)
  • The Algorithms are implemented for the OpenAI Gym env: CarRacing-v2

@theory-in-progress
Adding the Reinforcement Learning Template
557431b 
- Added 2 algorithms for Reinforcement Learning: REINFORCE and
    Advantage Actor Critic (A2C)
- The Algorithms are implemented for the OpenAI Gym env: CarRacing-v2
@netlify
Copy link

netlify bot commented Jul 12, 2023 •
edited
Loading

✅ Deploy Preview for code-generator ready!

Name Link
🔨 Latest commit 7619b24
🔍 Latest deploy log https://app.netlify.com/sites/code-generator/deploys/64e8c4c8f8a2520007124734
😎 Deploy Preview https://deploy-preview-276--code-generator.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@theory-in-progress theory-in-progress marked this pull request as draft July 12, 2023 16:58
guptaaryan16
guptaaryan16 reviewed Jul 13, 2023
View reviewed changes
src/templates/template-reinforcement-learning/advantage_actor_critic_a2c.py Outdated
eps = np.finfo(np.float32).eps.item()


class ActorCriticNetwork(nn.Module):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theory-in-progress @vfdev-5 I think it would be better if we define the network in a separate file so that it can be edited easily. Also I was looking at torchrl and I think it provides some abstactions over the contents of ActorCriticNetwork. Should we use it ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good point, I was also once thinking about torchrl and that we could use it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guptaaryan16 guptaaryan16 guptaaryan16 left review comments

@vfdev-5 vfdev-5 vfdev-5 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theory-in-progress @vfdev-5 @guptaaryan16