Skip to content

Conversation

abezukor
Copy link
Contributor

@abezukor abezukor commented Oct 2, 2025

Uses a trait for registering agents as IMO it is much more idiomatic then manually creating a

pub type RequestPassPhraseFn = Box<
    dyn (Fn() -> Pin<Box<dyn Future<Output = Result<String, Box<dyn std::error::Error>>> + Send>>)
        + Send
        + Sync,
>;

For completeness, I have also added the other possible methods to the agent trait.

@pythops
Copy link
Owner

pythops commented Oct 2, 2025

let's break it down into separate PR. that way it will be much easier to review :)

@abezukor abezukor changed the title Agent Trait and SignalLevelAgent Agent Trait Oct 2, 2025
@abezukor abezukor mentioned this pull request Oct 2, 2025
@abezukor
Copy link
Contributor Author

abezukor commented Oct 7, 2025

@pythops I broke the PR up (see #7). Any other comments?

@pythops
Copy link
Owner

pythops commented Oct 8, 2025

I will review all your PRs on Friday, busy these days with work sorry

@pythops
Copy link
Owner

pythops commented Oct 12, 2025

Excellent !

@pythops pythops merged commit 55587ea into pythops:main Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants