Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: censor password with toggle keybind #30

Merged
merged 2 commits into from
Feb 17, 2025
Merged

feat: censor password with toggle keybind #30

merged 2 commits into from
Feb 17, 2025

Conversation

OneRandom1509
Copy link
Contributor

Addresses issue #29

Changes:

  • Added a new boolean variable in App called show_password which manages the state of how the password should be displayed in the passkey field
  • Added a new keybind handler.rs for AuthKey, 'Tab' to toggle the state of show_password variable
  • Implementation of the censor done in ui.rs in the auth popup block

@OneRandom1509
feat: added censored password text field
f76d68f 
TODO: Add an option to see uncensored password with a keybind
@OneRandom1509
feat: added show password field in app state and keybind for toggle
9080c0d 
Added a new boolean field `show_password` and added "Tab" as its keybind
for toggling the variable
@pythops
Copy link
Owner

pythops commented Feb 17, 2025

amazing ❤️
I will look at it later, thanks a lot for the PR 🙏

@pythops
Copy link
Owner

pythops commented Feb 17, 2025

🎯

@pythops pythops merged commit 008b36f into pythops:main Feb 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OneRandom1509 @pythops