-
Notifications
You must be signed in to change notification settings - Fork 0
feat: pyconkr-shop API 호출을 위한 hook 추가 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MU-Software
wants to merge
16
commits into
main
Choose a base branch
from
feature/add-shop-api-hook
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MU-Software
commented
Apr 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new package structure to support the pyconkr-shop API calls and payment hooks while also adding shared utilities. Key changes include:
- Updates to Vite configuration for environment variables and path aliases.
- Addition of the Shop API utilities, schemas, hooks, and API client in the new @pyconkr-shop package.
- Inclusion of a common cookie utility in the @pyconkr-common package.
Reviewed Changes
Copilot reviewed 8 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
vite.config.ts | Added environment directory and alias configuration. |
package/pyconkr-shop/utils/portone.ts | Implemented API call helper for initiating PortOne purchase. |
package/pyconkr-shop/schemas/index.ts | Defined and exported shop API schemas. |
package/pyconkr-shop/hooks/index.ts | Provided hooks for API interactions using react-query. |
package/pyconkr-shop/apis/index.ts | Implemented API routes for shop-related actions. |
package/pyconkr-shop/apis/client.ts | Created an API client with error handling using axios. |
package/pyconkr-common/utils/cookie.ts | Added a simple cookie retrieval utility. |
Files not reviewed (5)
- dotenv/.env.development: Language not supported
- dotenv/.env.production: Language not supported
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
- tsconfig.app.json: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경 사항
@pyconkr-common
,@pyconkr-shop
,@src
패키지를 추가합니다.@pyconkr-common
: 공통적으로 사용될 util이 담기는 패키지@pyconkr-shop
: Shop API와 결제, Hook 등이 담기는 패키지@src
: src 디렉토리의 alias@pyconkr
패키지용 repo를 만들기 전에는 우선 별도 디렉토리에 구성해서, 나중에 마이그레이션이 쉽도록 했습니다 🙏