Skip to content

Commit 60535fc

Browse files
committed
Apply suggestion from @DragonMoffon in height.setter
1 parent 46b10ac commit 60535fc

File tree

1 file changed

+11
-8
lines changed

1 file changed

+11
-8
lines changed

arcade/sprite/base.py

Lines changed: 11 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -204,15 +204,18 @@ def height(self) -> float:
204204
@height.setter
205205
def height(self, new_value: float):
206206
size = self._size
207-
if new_value != size[1]:
208-
new_scale = Vec2(self._scale[0], new_value / self._texture.height)
209-
self._scale = new_scale
210-
self._hit_box.scale = new_scale
211-
self._size = Vec2(size[0], new_value)
212207

213-
self.update_spatial_hash()
214-
for sprite_list in self.sprite_lists:
215-
sprite_list._update_height(self)
208+
if new_value == size[1]:
209+
return
210+
211+
new_scale = Vec2(self._scale[0], new_value / self._texture.height)
212+
self._scale = new_scale
213+
self._hit_box.scale = new_scale
214+
self._size = Vec2(size[0], new_value)
215+
216+
self.update_spatial_hash()
217+
for sprite_list in self.sprite_lists:
218+
sprite_list._update_height(self)
216219

217220
@property
218221
def size(self) -> Vec2:

0 commit comments

Comments
 (0)