Skip to content

Commit 46b10ac

Browse files
committed
Use early return suggestion from @DragonMoffon
1 parent 5d65be0 commit 46b10ac

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

arcade/sprite/base.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -184,15 +184,17 @@ def width(self) -> float:
184184
@width.setter
185185
def width(self, new_value: float):
186186
size = self._size
187-
if new_value != size[0]:
188-
new_scale = Vec2(new_value / self._texture.width, self._scale[1])
189-
self._scale = new_scale
190-
self._hit_box.scale = new_scale
191-
self._size = Vec2(new_value, size[1])
187+
if new_value == size[0]:
188+
return
192189

193-
self.update_spatial_hash()
194-
for sprite_list in self.sprite_lists:
195-
sprite_list._update_width(self)
190+
new_scale = Vec2(new_value / self._texture.width, self._scale[1])
191+
self._scale = new_scale
192+
self._hit_box.scale = new_scale
193+
self._size = Vec2(new_value, size[1])
194+
195+
self.update_spatial_hash()
196+
for sprite_list in self.sprite_lists:
197+
sprite_list._update_width(self)
196198

197199
@property
198200
def height(self) -> float:

0 commit comments

Comments
 (0)