Updated the typing spec to use modern (PEP 695) generics syntax #2089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hauntsaninja
approved these changes
Sep 28, 2025
Co-authored-by: Shantanu <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Co-authored-by: Alex Waygood <[email protected]>
Collaborator
Author
|
Thanks for the review @AlexWaygood. I think I've addressed your feedback. I'm going to leave this unmerged a bit longer to give others a chance to review if they'd like. |
Member
JelleZijlstra
left a comment
JelleZijlstra
left a comment
There was a problem hiding this comment.
Need to run now, but noticed a few small things.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to update all places in the spec where the old-style
TypeVar,ParamSpecandTypeVarTupleconstructors are used in code samples, with the exception of samples that are intended to explain the older syntax. This should improve readability.Since it doesn't make any substantive changes to the spec, I don't think this requires approval from the full typing council, but it would be good to have a thorough review.