Small improvements to the conformance tests #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
approved these changes
Aug 1, 2025
Collaborator
|
LGTM. Thanks @rchen152! |
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Aug 3, 2025
Summary: Pulls in python/typing#2061. Reviewed By: ndmitchell Differential Revision: D79513775 fbshipit-source-id: 3261fa64f2df1be111576e380487f611e2925fb9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks to the conformance tests that I'm hoping are uncontroversial. Happy to split up this PR if any of these seem like they need more discussion.
yield, while mypy reports an error on just the return type. IMO both of these are reasonable choices, so I suggest we mark the error on theyieldas optional.@overrideline or thedefline. One error was missing a tag on thedefline, which I've added.dataclass_transformdecorator should not be applied to more than one of an overloaded function's overloads and implementation (https://typing.python.org/en/latest/spec/dataclasses.html#specification). dataclasses_transform_func.py applieddataclass_transformto two overloads of the same function, so I removed the decorator from the second overload.