Add conformance tests for the 'match_args' parameter to dataclass. #2056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The spec lists 'match_args' as a dataclass parameter that static type checkers must honor, so it would be good to have tests for it.
JelleZijlstra
approved these changes
Aug 16, 2025
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Aug 17, 2025
Summary: Updated conformance tests to pull in a few significant PRs: * python/typing#2067 (a fair number of small tweaks) * python/typing#2056 (new test file for dataclasses match_args) * python/typing#2068 (new test file for TypedDict extra items) Reviewed By: samwgoldman Differential Revision: D80424920 fbshipit-source-id: 3d8ac3e70aa86329f0d1adb1af2d2e0837bc5c4e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec lists 'match_args' as a dataclass parameter that static type checkers must honor [1], so it would be good to have tests for it.