conformance: dataclasses_inheritance.py - add missing # E #2017
+28
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KalininDL
changed the title
Collaborator
|
Thanks for the contribution. Yes, I agree this is missing an '# E'. Please rerun the conformance tests to update the results. Also, update the notes accordingly for any type checkers that fail this test so the notes appear in the conformance test results. |
KalininDL
force-pushed
the
fix_dataclasses_inheritance
branch
2 times, most recently
from
ebb8451 to
574e72f
Compare
KalininDL
force-pushed
the
fix_dataclasses_inheritance
branch
from
574e72f to
5df300b
Compare
erictraut
requested changes
Jun 5, 2025
| @@ -1,8 +1,9 @@ | |||
| conformant = "Pass" | |||
| conformant = "Partial" | |||
Collaborator
There was a problem hiding this comment.
Please add a "notes" section here with a one-line summary of the failure(s). These notes appear when hovering over the results in the conformance report.
Contributor
Author
There was a problem hiding this comment.
Aha, now I got how it works, thanks!
| @@ -1,8 +1,9 @@ | |||
| conformant = "Pass" | |||
| conformant = "Partial" | |||
Collaborator
There was a problem hiding this comment.
Same here — add a "notes" section and rerun the tests to produce an updated summary report.
KalininDL
force-pushed
the
fix_dataclasses_inheritance
branch
from
5df300b to
5e8b4f9
Compare
JelleZijlstra
approved these changes
Jun 6, 2025
intellij-monorepo-bot
pushed a commit
to JetBrains/intellij-community
that referenced
this pull request
Jun 9, 2025
…n/typing#2017 Add the test to `ignored.txt` as it passes now GitOrigin-RevId: eeb3fb89e5717a91482dc496233c3e68f5c4b80c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that # E is missing in the snippet bellow
Could you please take a look?