(🎁) conformance: NewType isn't a class
#2015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
changed the title
Newtype isn't a classNewtype isn't a class
erictraut
reviewed
May 28, 2025
KotlinIsland
changed the title
Newtype isn't a classNewType isn't a class
erictraut
approved these changes
Jun 4, 2025
JelleZijlstra
approved these changes
Jun 4, 2025
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Jul 23, 2025
Summary: I noticed that Danny submitted a couple PRs to make the conformance tests more flexible on what lines they expect certain errors on. This diff pulls in those changes, which give us a nice conformance boost. We do have a new conformance failure due to python/typing#2015. Reviewed By: yangdanny97 Differential Revision: D78778303 fbshipit-source-id: 256563b1f8e983263d2425708861d91dc00a4330
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i can't update the results on my machine, sorry!