Skip to content

Conformance - fix issues on Windows (unicode, Pyre) #1976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erictraut merged 2 commits into from
Apr 19, 2025
Merged

Conformance - fix issues on Windows (unicode, Pyre) #1976

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85ca00b
Conformance - fix saving toml results file in non-unicode
Andrej730 Apr 19, 2025
dfad1b7
Conformance - skip Pyre on Windows as it's not supported
Andrej730 Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion conformance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,8 @@ To run the conformance test suite:
* Switch to the `conformance` subdirectory and install all dependencies (`pip install -r requirements.txt`).
* Switch to the `src` subdirectory and run `python main.py`.

Note that some type checkers may not run on some platforms. If a type checker fails to install, tests will be skipped for that type checker.
Note that some type checkers may not run on some platforms. If a type checker fails to install, tests will be skipped for that type checker.
Currently, the only unsupported type checker is Pyre on Windows.

## Reporting Conformance Results

Expand Down
2 changes: 1 addition & 1 deletion conformance/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,5 @@ tqdm
pyright
mypy
pip
pyre-check
pyre-check; platform_system != "Windows"
pytype
2 changes: 1 addition & 1 deletion conformance/src/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,7 @@ def update_output_for_test(
notes = "\n" + notes
existing_results["notes"] = tomlkit.string(notes, multiline=True)
results_file.parent.mkdir(parents=True, exist_ok=True)
with open(results_file, "w") as f:
with open(results_file, "w", encoding="utf-8") as f:
tomlkit.dump(existing_results, f)


Expand Down
2 changes: 1 addition & 1 deletion conformance/src/type_checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,6 @@ def parse_errors(self, output: Sequence[str]) -> dict[int, list[str]]:
TYPE_CHECKERS: Sequence[TypeChecker] = (
MypyTypeChecker(),
PyrightTypeChecker(),
PyreTypeChecker(),
*([] if os.name == "nt" else [PyreTypeChecker()]),
PytypeTypeChecker(),
)