Assign all TypeVars to variables #1959
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the fix. Looks good to me. |
facebook-github-bot
pushed a commit
to facebook/pyrefly
that referenced
this pull request
Apr 5, 2025
Summary: I made a fix to the conformance tests, so I'm pulling in the latest changes and regenerating the outputs. python/typing#1959 This also pulled in the new overload conformance tests. Reviewed By: ndmitchell Differential Revision: D72514863 fbshipit-source-id: 5a06f65d3738a2152ae864122c9c9b5691570b16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a few places in the conformance tests that had calls to
TypeVarwithout assigning them to variables. This PR changes them to be assigned to variables, for consistency.Based on the results, it appears that some existing typecheckers do not check TypeVars that are not assigned to variables, so the typechecker logic did not get exercised previously.