Skip to content

Conversation

@erictraut
Copy link
Collaborator

No description provided.

@erictraut erictraut requested a review from JelleZijlstra March 10, 2025 20:00
Copy link
Member

@carljm carljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Comment on lines +140 to +141
Line 164: Unexpected errors ["qualifiers_final_annotation.py:164:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: Can't find module '_qualifiers_final_annotation_1'. [import-error]"]
Line 168: Unexpected errors ["qualifiers_final_annotation.py:168:1: \\x1b[1m\\x1b[31merror\\x1b[39m\\x1b[0m: in <module>: Can't find module '_qualifiers_final_annotation_2'. [import-error]"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems pytype can't find the helper modules at all? This suggests the root problem here is something in the conformance tests' path setup for pytype.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may need help from pytype maintainers here.

So far, I haven't seen any interest expressed by the pytype maintainers to be conformant with the typing spec, so maybe we should drop pytype from the test entirely? Maintaining support for pytype has been a bit of a burden (much more so than the other three type checkers), and I haven't seen any sign that anyone (including the pytype team) care about the results of these tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there will be pytype maintainers at the PyCon typing summit, so I can discuss this general topic with them there. I don't think figuring out this issue needs to block this PR.

@erictraut erictraut merged commit be7ba97 into python:main Mar 11, 2025
4 checks passed
@erictraut erictraut deleted the imported_final_conformance branch March 11, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants